Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: throwing an invalid_stride error when the size provided to wl_shm::create_pool is less than or equal to zero #3674

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feature: throwing an invalid_stride error when the size provided to wl_shm::create_pool is less than or equal to zero #3674

merged 1 commit into from
Nov 18, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Nov 18, 2024

I encountered this while running cosmic-bg on Mir. It still doesn't fix the problems there, but it avoids us blowing up in mmap

@mattkae
feature: throwing an invalid_stride error when the size provided to w…
b5407fd 
…l_shm::create_pool is less than or equal to zero
@mattkae mattkae requested a review from Saviq November 18, 2024 14:16
@mattkae mattkae requested a review from a team as a code owner November 18, 2024 14:16
AlanGriffiths
AlanGriffiths approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit b19c667 Nov 18, 2024
30 of 39 checks passed
@AlanGriffiths AlanGriffiths deleted the bugfix/shm_create_pool_protocol_error branch November 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@Saviq Saviq Awaiting requested review from Saviq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkae @AlanGriffiths